-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(stateDirective): using on to attach an event handler instead of bind #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stateDirective): using on to attach an event handler instead of bind #3036
Conversation
This is a BC-break. We can add support for |
Yes @nateabele, it's a breaker. element.bind ? element.bind("click", hookFn) : element.on("click", hookFn); or this: element.[element.bind ? 'bind' : 'on']("click", hookFn); Should I try to use |
I think I merged a similar commit into master |
@navarroaxel we would want to try |
269ef7a
to
4510f6b
Compare
4510f6b
to
e8a0956
Compare
Hey @christopherthielen, are you saying this commit is useless because it was covered by another one? |
Hey @nateabele, I have change the code to be keep the BC. |
I think I merged a similar commit on |
Thanks! |
Yup, thanks @navarroaxel. |
fix #3035